[PATCH] D79398: [WIP][dsymutil] Add reproducers to dsymutil

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 04:16:17 PDT 2020


avl added inline comments.


================
Comment at: llvm/tools/dsymutil/Reproducer.cpp:41
+  FC->writeMapping(Mapping.str());
+  errs() << "Reproducer written to " << Root << '\n';
+}
----------------
JDevlieghere wrote:
> avl wrote:
> > It looks like it is not an error, but just logging. Thus it should probably be put under Verbose flag?
> > 
> > 
> > ```
> > if (Options.Verbose)
> >       outs() << "Reproducer written"
> > ```
> It's more than logging, it's the only way to find out where the reproducer has been written. I'll change it to `outs()`, but I don't think it should be behind the `Verbose` flag. 
> 
> 
> 
I see. Let it be just outs() then.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79398/new/

https://reviews.llvm.org/D79398





More information about the llvm-commits mailing list