[PATCH] D79114: [lld-macho] Dylib symbols should always replace undefined symbols

Wed May 6 00:30:12 PDT 2020

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM.

In D79114#2021626 <https://reviews.llvm.org/D79114#2021626>, @int3 wrote:

> > where can we find authoritative symbol resolution rules?
>
> I guess the authoritative source is whatever ld64 is doing. I took a brief look at their SymbolTable.cpp but it seems rather complex, handling many kinds of symbols. The test behavior in this diff does emulate the observed behavior of ld64 though.
>
> Thanks for the pointer to the ELF resolution rule design, will keep that in mind as we expand support for symbol kinds.

I added some commentary on ld64's behavior in https://reviews.llvm.org/D78342#inline-728182.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79114/new/

https://reviews.llvm.org/D79114