[llvm] 0c4aab2 - [NFC] Outliner label name clean up.

Puyan Lotfi via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 20:28:14 PDT 2020


Author: Puyan Lotfi
Date: 2020-05-05T23:27:46-04:00
New Revision: 0c4aab27b3da05dd1b0c0c39472525325fda5e23

URL: https://github.com/llvm/llvm-project/commit/0c4aab27b3da05dd1b0c0c39472525325fda5e23
DIFF: https://github.com/llvm/llvm-project/commit/0c4aab27b3da05dd1b0c0c39472525325fda5e23.diff

LOG: [NFC] Outliner label name clean up.

Just simplifying how the label name is generated while using
std::to_string instead of Twine.

Differential Revision: https://reviews.llvm.org/D79464

Added: 
    

Modified: 
    llvm/lib/CodeGen/MachineOutliner.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MachineOutliner.cpp b/llvm/lib/CodeGen/MachineOutliner.cpp
index dd1dd2cdd8c2..8bd02f0ed24a 100644
--- a/llvm/lib/CodeGen/MachineOutliner.cpp
+++ b/llvm/lib/CodeGen/MachineOutliner.cpp
@@ -1110,13 +1110,10 @@ MachineFunction *MachineOutliner::createOutlinedFunction(
   // Create the function name. This should be unique.
   // FIXME: We should have a better naming scheme. This should be stable,
   // regardless of changes to the outliner's cost model/traversal order.
-  std::string FunctionName;
+  std::string FunctionName = "OUTLINED_FUNCTION_";
   if (OutlineRepeatedNum > 0)
-    FunctionName = ("OUTLINED_FUNCTION_" + Twine(OutlineRepeatedNum + 1) + "_" +
-                    Twine(Name))
-                       .str();
-  else
-    FunctionName = ("OUTLINED_FUNCTION_" + Twine(Name)).str();
+    FunctionName += std::to_string(OutlineRepeatedNum + 1) + "_";
+  FunctionName += std::to_string(Name);
 
   // Create the function using an IR-level function.
   LLVMContext &C = M.getContext();


        


More information about the llvm-commits mailing list