[PATCH] D79269: [NativeSession] Implement NativeSession::findSymbolByAddress.

[Amy Huang via Phabricator via llvm-commits]

akhuang updated this revision to Diff 262270.
akhuang marked 2 inline comments as done.
akhuang added a comment.

Address comments
-check for overlap before inserting into IntervalMap and just ignore any overlapping sections
-change function names from -ByAddress to -BySectOffset

I also fixed a few other things
-changed public symbol search to search by upper bound instead of exact match
-function symbol search now searches within the address range (offset+codesize), instead
of just the starting address


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79269/new/

https://reviews.llvm.org/D79269

Files:
  llvm/include/llvm/DebugInfo/PDB/DIA/DIASession.h
  llvm/include/llvm/DebugInfo/PDB/IPDBSession.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h
  llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
  llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
  llvm/lib/DebugInfo/PDB/CMakeLists.txt
  llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
  llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/test/tools/llvm-symbolizer/pdb/pdb-native.test
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
  llvm/unittests/DebugInfo/PDB/NativeSessionTest.cpp
  llvm/unittests/DebugInfo/PDB/PDBApiTest.cpp
  llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79269.262270.patch
Type: text/x-patch
Size: 33062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200506/20fc7c42/attachment.bin>