[PATCH] D78923: [LLD] [COFF] Add an option for disabling runtime pseudo relocs

Tue May 5 17:49:33 PDT 2020

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

================
Comment at: lld/COFF/Options.td:187
 // LLD extensions
+defm runtime_pseudo_reloc : B<"runtime-pseudo-reloc", "", "">;
 def end_lib : F<"end-lib">,
----------------
mstorsjo wrote:
> It would be nice to be able to omit the HelpText for the two options here (to hide the option from the help listing), when using `B<>` style options for private options, but the current form of `multiclass B<...` doesn't allow omitting those strings and unconditionally adds HelpText, which includes it in the listing. I'm not nearly familiar enough with tablegen to know what's possible to do, though.
I suppose the best option I can think of is two `def Flag` variants.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78923/new/

https://reviews.llvm.org/D78923