[PATCH] D76997: Fix StringRef::strLen in windows with clang++ C++17

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 16:12:47 PDT 2020


rnk added a comment.

If the compiler has the builtin, IMO we should prefer the builtin. It's always going to be better and faster than the library implementation. I would recommend reordering the ifdefs to prefer `__builtin_strlen` over the STL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76997/new/

https://reviews.llvm.org/D76997





More information about the llvm-commits mailing list