[PATCH] D79429: [mlir] Add missing dependency to MLIRMlirOptMain

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/tools/mlir-opt/CMakeLists.txt:47
+  intrinsics_gen
+  mlir-headers
   )
----------------
antiagainst wrote:
> mehdi_amini wrote:
> > Can you clarify which header included from `mlir-opt.cpp` depends on these?
> InitAllDialects.h. Do you want me to add as a comment to the code? Happy to send out a patch for it if so. 
I'd rather cut the dependency :)
I don't think calling into the initialization of dialect should require generated headers: this seems like a rather fundamentally static method.

It seems that this is due to template initialization, we could get away with an indirection, I'll look into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79429/new/

https://reviews.llvm.org/D79429