[PATCH] D79390: [Support] Sink LLD's parallel algorithm wrappers to support
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 5 15:08:46 PDT 2020
aganea added a comment.
LGTM as well, thank you!
================
Comment at: lld/lib/ReaderWriter/MachO/LayoutPass.cpp:464
std::vector<LayoutPass::SortKey> vec = decorate(atomRange);
- sort(llvm::parallel::par, vec.begin(), vec.end(),
- [&](const LayoutPass::SortKey &l, const LayoutPass::SortKey &r) -> bool {
- return compareAtoms(l, r, _customSorter);
- });
+ llvm::parallelSort(
+ vec.begin(), vec.end(),
----------------
Could this be `llvm::parallelSort(vec, ...)`?
================
Comment at: llvm/unittests/Support/ParallelTest.cpp:33
- sort(parallel::par, std::begin(array), std::end(array));
+ parallelSort(std::begin(array), std::end(array));
ASSERT_TRUE(llvm::is_sorted(array));
----------------
`parallelSort(array)`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79390/new/
https://reviews.llvm.org/D79390
More information about the llvm-commits
mailing list