[PATCH] D79355: Mark values as trivially dead when their only use is a start or end lifetime intrinsic.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Minor things that can be addressed prior to the commit. Otherwise, LGTM. Thx.



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:414
+                 isa<Argument>(Arg)) {
+        return llvm::all_of(II->getArgOperand(1)->uses(), [](Use &Use) {
+          if (IntrinsicInst *IntrinsicUse =
----------------
`auto *Arg =`

no else after return.

-`II->getArgOperand(1)`
+`Arg`



================
Comment at: llvm/test/Transforms/DCE/basic.ll:53
+}
+
 ; CHECK: [[add]] = !DILocalVariable
----------------
Add one negative test, bitcast + lifetime marker, with a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79355/new/

https://reviews.llvm.org/D79355