[PATCH] D79444: [mlir][spirv] NFC: Remove template functions for getting op's opcode

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 14:03:46 PDT 2020


antiagainst created this revision.
antiagainst added reviewers: mehdi_amini, hanchung.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, bader, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, jpienaar, rriddle.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a child revision: D79446: [mlir][spirv] NFC: Serialize all operands together if possible.
antiagainst added a reviewer: denis13.
antiagainst retitled this revision from "[mlir][spirv] Remove template functions for getting op's opcode" to "[mlir][spirv] NFC: Remove template functions for getting op's opcode".

These template functions are used in the serializer, where we can
actually directly query the opcode from the op's definition and
use that in the auto-generated serialization logic.

This removes a set of templates accounting for 319 lines from
the auto-generated inc file.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79444

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVBinaryUtils.h
  mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
  mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79444.262214.patch
Type: text/x-patch
Size: 4372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200505/bd2762d7/attachment.bin>


More information about the llvm-commits mailing list