[PATCH] D79233: [ARM] Refactor lower to S[LR]I optimization

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 10:46:54 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

It's not obvious to me from reading the testcase that we have test coverage code for both the BICi and the isAllConstantBuildVector case; please check before merging.

Probably it would be worth looking into pattern-matching cases that don't involve precisely the AND you're looking for, using computeKnownBits.  But that doesn't need to happen here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79233/new/

https://reviews.llvm.org/D79233





More information about the llvm-commits mailing list