[PATCH] D77223: [LLVM] sys::path::replace_path_prefix fix and simplifications

Sylvain Audi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 09:41:42 PDT 2020


saudi updated this revision to Diff 262131.
saudi added a subscriber: amccarth.
saudi added a comment.

Added `Style` parameter to `replace_path_prefix`, as suggested.
This allowed to make the `replace_path_prefix` unit-test platform independent, removing a `#ifdef _WIN32` that I added in a previous version of the patch.

The tests `ninja check-all` passed on windows.
@amccarth : Does it cover all the VFS tests you suggested that I double-check?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77223/new/

https://reviews.llvm.org/D77223

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/Lex/PPMacroExpansion.cpp
  clang/test/Preprocessor/Inputs/include-file-test/file_test.h
  clang/test/Preprocessor/file_test.c
  clang/test/Preprocessor/file_test.h
  clang/test/Preprocessor/file_test_windows.c
  llvm/include/llvm/Support/Path.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/MC/MCContext.cpp
  llvm/lib/Support/Path.cpp
  llvm/unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77223.262131.patch
Type: text/x-patch
Size: 12735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200505/76c133bd/attachment.bin>


More information about the llvm-commits mailing list