[PATCH] D79386: [MemorySSA] Make MemoryLocation unknown when phi translation cannot be performed.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

lgtm with one nit. thanks!



================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1232
+      } else {
+        Location.setSizeToUnknown();
       }
----------------
AIUI, generally we try to treat MemoryLocations and LocationSizes as immutable. so we can keep with that, do you think `Location = Location.getWithNewSize(LocationSize::unknown());` (and reverting the changes to MemoryLocation.h) is an acceptable alternative?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79386/new/

https://reviews.llvm.org/D79386