[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 09:08:40 PDT 2020


jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5287
-    // If there exists a user-declared function whose name is the same as the
-    // ExternalSymbol's, then we pick up the user-declared version.
-    const Module *Mod = DAG.getMachineFunction().getFunction().getParent();
----------------
jasonliu wrote:
> > // If there exists a user-declared function whose name is the same as the 
> > // ExternalSymbol's, then we pick up the user-declared version.
> How do we handle this scenario under the new logic? Are we still able to pick up the user-declared version without generating .extern for that function? 
Please consider the case in llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78929/new/

https://reviews.llvm.org/D78929





More information about the llvm-commits mailing list