[PATCH] D76786: [ARM][MVE] Add support for incrementing gathers

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:495
+    return cast<IntrinsicInst>(
+        tryCreateMaskedGatherBase(I, OffsetsIncoming, Builder, Immediate));
+  else
----------------
I feel like this should be using BasePtr somewhere?


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:502
+
+Value *MVEGatherScatterLowering::tryCreateIncrementingWBGather(
+    IntrinsicInst *I, Value *BasePtr, Value *Offsets, unsigned TypeScale,
----------------
This looks OK. Can you add one extra check somewhere that gep has a single user? As the phi is changing and the gep uses the phi.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76786/new/

https://reviews.llvm.org/D76786