[PATCH] D79398: [WIP][dsymutil] Add reproducers to dsymutil

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

generally it looks good for me, I only have a couple of inline comments.



================
Comment at: llvm/tools/dsymutil/Reproducer.cpp:41
+  FC->writeMapping(Mapping.str());
+  errs() << "Reproducer written to " << Root << '\n';
+}
----------------
It looks like it is not an error, but just logging. Thus it should probably be put under Verbose flag?


```
if (Options.Verbose)
      outs() << "Reproducer written"
```


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:101
   unsigned NumThreads;
+  ReproducerMode ReproMode;
   dsymutil::LinkOptions LinkOpts;
----------------
it would be good to initialize this:
ReproMode = ReproducerMode::Off;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79398/new/

https://reviews.llvm.org/D79398