[PATCH] D76278: [AMDGPU] Don't mark the .note section as ALLOC

Tue May 5 04:48:38 PDT 2020

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM. My suggestion would be to leave a TODO comment for the OpenCL thing and go ahead.

================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:441-443
+  unsigned NoteFlags = 0;
+  if (Os == Triple::AMDHSA)
+    NoteFlags = ELF::SHF_ALLOC;
----------------
t-tye wrote:
> Why does the AMDHSA ABI need this note section to be allocated?
> 
> @kzhuravl do you have any information about this?
Since we seem to have been unable to make progress on this OpenCL question, I would suggest to add a comment here saying that part of the OpenCL runtime relies on that, and add a link to that review (even though I agree that it's not particularly enlightening).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76278/new/

https://reviews.llvm.org/D76278