[PATCH] D79399: [CodeGen] Fix incorrect uses of getVectorNumElements()
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 5 02:39:19 PDT 2020
sdesmalen added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/sve-ext-trunc.ll:1
+; REQUIRES: asserts
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
----------------
You can drop `REQUIRES: asserts` since this test is equally valid without asserts.
================
Comment at: llvm/test/CodeGen/AArch64/sve-ext-trunc.ll:6
+; CHECK-LABEL: sext_i8toi16
+; CHECK: sxtb z0.h, p{{[0-7]}}/m, z0.h
+entry:
----------------
missing `CHECK-NEXT: ret`
For a patch like this, you can also generate the CHECK lines with the `update_llc_test_checks.py` script.
================
Comment at: llvm/test/CodeGen/AArch64/sve-ext-trunc.ll:102
+define <vscale x 8 x i8> @trunc_i16toi8(<vscale x 8 x i16> %in) {
+; CHECK-LABEL: trunc_i16toi8
+entry:
----------------
If this is a no-op, please add a `CHECK-NEXT: ret`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79399/new/
https://reviews.llvm.org/D79399
More information about the llvm-commits
mailing list