[PATCH] D79306: llvm rejects DWARF operator DW_OP_push_object_address.

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:1
+; This test checks whether DWARF operator DW_OP_push_object_address
+; is accepted and processed.
----------------
djtodoro wrote:
> alok wrote:
> > alok wrote:
> > > djtodoro wrote:
> > > > The recommendation is (I've learned this recently) using double `;` for high-level comments.
> > > Thanks for your comment.  sorry I did not understand it clearly. Do you mean double semi colon ";;" in place of ";"?
> > Thanks for your comment, I shall update my patch.
> Yes. Thanks.
Sorry for the confusion, but this should be:

  ;; This test checks whether DWARF operator DW_OP_push_object_address
  ;; is accepted and processed.




================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:22
+; step 2: insert DW_OP_push_object_address in dbg.declare instruction
+; This is meaningless test case focused to test DW_OP_push_object_address.
+
----------------
  ;; Below is the original test case this IR is generated from
  ;;---------------------------
  ;;int main() {
  ;;int var;
  ;;return var;
  ;;}
  ;;---------------------------
  ;; step 1: generate IR using -g -O0 -S -emit-llvm
  ;; step 2: insert DW_OP_push_object_address in dbg.declare instruction
  ;; This is meaningless test case focused to test DW_OP_push_object_address.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79306/new/

https://reviews.llvm.org/D79306