[PATCH] D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store.
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 5 02:06:38 PDT 2020
vitalybuka added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:951
+ IRBuilder<> ThenIRB(ThenTerm);
+ auto Store = ThenIRB.CreateStore(ConstantInt::getTrue(Int1Ty), FlagPtr);
+ SetNoSanitizeMetadata(Load);
----------------
vitalybuka wrote:
> This should be the opposite?
> I'll fix this.
Now:
```
if (Load) {
Store
}
```
should be :
```
if (!Load) {
Store
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79392/new/
https://reviews.llvm.org/D79392
More information about the llvm-commits
mailing list