[PATCH] D79375: [FileCheck] Make invalid prefix diagnostics more precise
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 5 01:34:31 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/lib/Support/FileCheck.cpp:1884
+static bool ValidatePrefixes(StringSet<> &PrefixSet,
+ const std::vector<StringRef> &Prefixes) {
+ for (StringRef Prefix : Prefixes) {
----------------
jhenderson wrote:
> `ArrayRef`
Also, could you name these variables more distinctly so that it's obvious which is which by name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79375/new/
https://reviews.llvm.org/D79375
More information about the llvm-commits
mailing list