[PATCH] D79359: OpenMPOpt Remarks Support

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Looks pretty good. Some minor comments



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:511
+        [&]() { return RemarkCB(RemarkKind(DEBUG_TYPE, RemarkName, Inst)); });
+  }
+
----------------
Nit: getFunction()

auto & or auto *, please.

Do you need a default for the callback type?


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:560
+    return std::make_unique<OptimizationRemarkEmitter>(std::move(ORE));
+  };
+
----------------
I don't think it's a good idea to move the result here. Just return a reference. 


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:612
+      return std::make_unique<OptimizationRemarkEmitter>(F);
+    };
+
----------------
Call getAnalysis here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79359/new/

https://reviews.llvm.org/D79359