[PATCH] D79296: [mlir][DenseElementsAttr] Add support for opaque APFloat/APInt complex values.

Smit Hinsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 16:41:41 PDT 2020


Smit added a comment.

Neat!



================
Comment at: mlir/unittests/IR/AttributeTest.cpp:30
   for (auto newValue : detectedSplat.template getValues<EltTy>())
-    EXPECT_EQ(newValue, splatElt);
+    EXPECT_TRUE(newValue == splatElt);
 }
----------------
Also, dump the values?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79296/new/

https://reviews.llvm.org/D79296





More information about the llvm-commits mailing list