[PATCH] D79311: [lld-macho] Support X86_64_RELOC_SIGNED_{1,2,4}

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/test/MachO/x86-64-reloc-signed.s:17
+_main:
+  movl $0x434241, _s(%rip)  # X86_64_RELOC_SIGNED4
+  callq _f
----------------
alexshap wrote:
> smeenai wrote:
> > int3 wrote:
> > > nit: X86_64_RELOC_SIGNED_4 (missing underscore)
> > (same nit for the two below)
> btw, is there a guarantee that MC will emit a relocation of this particular type ? (and the same question might be relevant for other similar diffs). One way to (at least) verify it is to use llvm-objdump or llvm-readobj to check that the list of relocations contains exactly what's expected here. 
Good point, and yeah, that seems worthwhile to check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79311/new/

https://reviews.llvm.org/D79311