[PATCH] D79360: [DAGCombiner] sink target-supported cast op after concat vectors

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/test/CodeGen/X86/avx-shift.ll:177
+; CHECK-NEXT:    vinsertf128 $1, %xmm1, %ymm0, %ymm0
+; CHECK-NEXT:    vcvttps2dq %ymm0, %ymm0
 ; CHECK-NEXT:    retq
----------------
craig.topper wrote:
> Do we do the best thing if the shl is used by another operation that needs to be split? Do we keep the vcvttps2dq split?
Does the next test (vshift08_add) cover the scenario you're thinking of? There's no difference on that one because the concat isn't directly after the cast.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79360/new/

https://reviews.llvm.org/D79360