[PATCH] D78306: [flang] Use LLVM's flags

Mon May 4 13:27:08 PDT 2020

tskeith added a comment.

In D78306#2018333 <https://reviews.llvm.org/D78306#2018333>, @DavidTruby wrote:

> In D78306#2018241 <https://reviews.llvm.org/D78306#2018241>, @tskeith wrote:
>
> > With this change is it possible to enable `-Werror` for flang (in an in-tree build) without enabling it for all of LLVM? Also, `-pedantic`?
>
>
> Could you let us know why you think this is necessary when LLVM_ENABLE_WERROR and LLVM_ENABLE_PEDANTIC exist?
>
> It's perfectly acceptable to stand up build bots that enable these two flags and enforce that those build bots always pass in master; I just really don't think we want these flags by default when new compiler releases after our own releases (and therefore completely out of our control) can cause build failures with these flags.

I want to make sure that my flang changes (and everyone else's) build without warnings from the compilers I test with. `LLVM_ENABLE_WERROR` etc. is fine if LLVM and MLIR don't have any warnings, but that hasn't been my experience.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78306/new/

https://reviews.llvm.org/D78306