[PATCH] D78190: Add Bfloat IR type

Mon May 4 13:27:07 PDT 2020

fpetrogalli added a comment.

Hi @stuij,

thank you for working on this!

Admittedly, I don't know much about the Asm parser, but I have left some comments anyway.

1. Shouldn't we test also that the parser is happy with the following expressions?

  bfloat *
  %... = fadd <bfloat x 4> %..., %... 
  similar for <vscale x bfloat x 8>

Or is this not needed, or left to be done in a separate patch?

2. Would it make sense to to split this patch into 2 separate patches? One that defines the enums and interfaces for `bfloat`, and one that does the actual parsing/emission in the IR? I suspect there is much intertwine going on, so probably not - in that case, I am happy for everything to go via a single patch.

3. Do you need those changes in the Hexagon and x86 backend? Could they be submitted separately, with some testing?

Kind regards,

Francesco

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78190/new/

https://reviews.llvm.org/D78190