[PATCH] D79353: [AMDGPU] Better support for VMEM soft clauses in GCNHazardRecognizer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:515-516
 
-    if (IsSMRD != SIInstrInfo::isSMRD(*MI))
+    if (IsSMRD ? !SIInstrInfo::isSMRD(*MI)
+               : (!SIInstrInfo::isVMEM(*MI) && !SIInstrInfo::isFLAT(*MI)))
       break;
----------------
It might be clearer to split this into a breaksSMEMClause(MI) and breaksVMEMClause(MI)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79353/new/

https://reviews.llvm.org/D79353