[PATCH] D79350: Don't check for inalloca in IPConstantPropagation

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added reviewers: hans, rnk.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
aeubanks updated this revision to Diff 261893.
aeubanks added a comment.

Wrong version...


This was added in https://reviews.llvm.org/D2449, but I'm not sure it's
necessary since an inalloca value is never a Constant (should be an
AllocaInst).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79350

Files:
  llvm/lib/Transforms/IPO/IPConstantPropagation.cpp


Index: llvm/lib/Transforms/IPO/IPConstantPropagation.cpp
===================================================================
--- llvm/lib/Transforms/IPO/IPConstantPropagation.cpp
+++ llvm/lib/Transforms/IPO/IPConstantPropagation.cpp
@@ -129,7 +129,7 @@
   for (unsigned i = 0, e = ArgumentConstants.size(); i != e; ++i, ++AI) {
     // Do we have a constant argument?
     if (ArgumentConstants[i].getInt() || AI->use_empty() ||
-        AI->hasInAllocaAttr() || (AI->hasByValAttr() && !F.onlyReadsMemory()))
+        (AI->hasByValAttr() && !F.onlyReadsMemory()))
       continue;
 
     Value *V = ArgumentConstants[i].getPointer();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79350.261893.patch
Type: text/x-patch
Size: 634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200504/e8e6ab11/attachment.bin>