[PATCH] D79092: [Flang][Driver]Add new flang driver main() entrypoint

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added a comment.

In D79092#2017168 <https://reviews.llvm.org/D79092#2017168>, @CarolineConcatto wrote:

> @schweitz Ok, I am open to solutions for the concern @sscalpone brought. 
>  I suggested the flag because I can see it is what is done with MLIR for FIR.
>  ATM it is not possible to remove clang from the libraries because the Driver class is inside clang. 
>  Probably the Driver class will need to be refactored in the future, maybe when we have a stable flang driver. 
>  But for now, it will only delay more flang driver functionality.


My point is that if you make it optional, others may understand that to mean it is not a first-class part of the compiler. You risk having changes that simply do not consider it. I believe "optional FIR" was a mistake and it should have been removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79092/new/

https://reviews.llvm.org/D79092