[PATCH] D79291: [llvm-profdata] Support -detailed-summary for Sample Profile

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 11:16:06 PDT 2020


wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:839
+
+static void showDetailedSummary(ProfileSummary &PS, raw_fd_ostream &OS) {
+  OS << "Detailed summary:\n";
----------------
wmi wrote:
> Can we make it a member function of ProfileSummary? We may use the dump function in other places.
> 
> 
Sure, moved both to be member functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79291/new/

https://reviews.llvm.org/D79291





More information about the llvm-commits mailing list