[PATCH] D76135: [MachineLICM] Don't treat cross copies as cheap

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 10:44:15 PDT 2020


qcolombet added inline comments.
Herald added a project: LLVM.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1173
+  const TargetRegisterInfo &TRI = *MRI.getTargetRegisterInfo();
+  return !TRI.shareSameRegisterFile(DstRC, DstSubIdx, SrcRC, SrcSubIdx);
+}
----------------
I feel we should stick to shouldRewriteCopySrc to take into account the "cheapness" of the copy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76135/new/

https://reviews.llvm.org/D76135





More information about the llvm-commits mailing list