[PATCH] D76132: [LoopUnrollAndJam] Changed safety checks to consider more than 2-levels loop nest.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 09:37:42 PDT 2020


Meinersbur added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp:792
+    for (size_t i = 0; i < NumInsts; ++i) {
+      for (size_t j = i + 1; j < NumInsts; ++j) {
+        if (!checkDependency(CurrentLoadsAndStores[i], CurrentLoadsAndStores[j],
----------------
Meinersbur wrote:
> This should be ` for (size_t j = i; j < NumInsts; ++j)` to not skip over self-dependencies of a store.
Could you please address this comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76132/new/

https://reviews.llvm.org/D76132





More information about the llvm-commits mailing list