[PATCH] D79073: [AMDGPU] For PAL, make sure Scratch Buffer Descriptor do not clobber GIT pointer

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu marked 6 inline comments as done.
RamNalamothu added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/SRSRC-GIT-clobber-check.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=amdgcn--amdpal -mcpu=gfx1010 -run-pass=prologepilog -o - %s | FileCheck %s
----------------
arsenm wrote:
> Comment seems to be a lie. The label and some instructions are missing 
Missed to clean it up from the update_mir_test_checks.py o/p.


================
Comment at: llvm/test/CodeGen/AMDGPU/SRSRC-GIT-clobber-check.mir:28
+  ; CHECK:   $sgpr4 = S_MOV_B32 $sgpr8, implicit-def $sgpr4_sgpr5_sgpr6_sgpr7
+  ; CHECK:   $sgpr4_sgpr5_sgpr6_sgpr7 = S_LOAD_DWORDX4_IMM $sgpr4_sgpr5, 0, 0, 0, implicit-def $sgpr4_sgpr5_sgpr6_sgpr7 :: (dereferenceable invariant load 16, align 4, addrspace 4)
+  bb.0:
----------------
arsenm wrote:
> Odd that we ended up with a def and implicit def of the same register
Not being introduced by the current changes.

If that's a preexisting bug, will be looked separately. @scott.linder FYI


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79073/new/

https://reviews.llvm.org/D79073