[PATCH] D79127: [XCOFF][AIX] Emit correct alignment for csect

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:624
+  if (Type != XCOFF::XTY_ER)
+    Result->setAlignment(Align(4));
   Entry.second = Result;
----------------
how about to define static const expr DefaultAlign=4 ; in the MCSectionXCOFF  class ?


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:61
+  cast<MCSymbolXCOFF>(Symbol)->getRepresentedCsect()->setAlignment(
+      Align(ByteAlignment));
 
----------------
do we need to add safeguard of   cast<MCSymbolXCOFF>(Symbol)->hasRepresentedCsect() here ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79127/new/

https://reviews.llvm.org/D79127