[PATCH] D79309: [llvm-objdump] -d: delete spaces among raw instruction bytes

[Peter Smith via Phabricator via llvm-commits]

psmith added a comment.

I don't have a strong opinion here, the spaced bytes more closely match the output of the llvm-mc which can make disassembler tests easier to write. On the other hand it can be useful to see the structure of the disassembly of instructions when the mapping symbols exist. 
Arm GNU objdump does the following:

  address: 12345678 <spaces> <disassembly of arm instruction
  address: 1234 5678 <spaces> for 32-bit Thumb instruction made up of two half words
  address: 1234 <spaces> for 16-bit Thumb instruction made up a half word
  address: 12345678 <spaces> for .word 0x12345678

I don't have a lot of experience of non Arm RISC architectures though so I don't know what looks reasonable for them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79309/new/

https://reviews.llvm.org/D79309