[PATCH] D79284: [llvm-objdump][ARM] Print inline relocations when dumping ARM data

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 08:32:44 PDT 2020


MaskRay added a comment.

In D79284#2017321 <https://reviews.llvm.org/D79284#2017321>, @rovka wrote:

> Hi, I like that we're looping in only one place now, but I have 2 nitpicks:
>
> 1. The formatting changes are pretty distracting, I think you should commit them separately.
> 2. The commit message should explain what the problem is and why this change fixes it. Just referencing a bug number, where there haven't even been any discussions, is not very helpful. Thanks!


The else branch of `if (DumpARMELFData) {` increases indentation, thus causing some minor code/comment formatting. Phabricator is smart enough to hide indentation changes, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79284/new/

https://reviews.llvm.org/D79284





More information about the llvm-commits mailing list