[PATCH] D79305: chrono: check _POSIX_TIMERS before using clock_gettime

Mara Sophie Grosch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 08:32:36 PDT 2020


LittleFox94 added a comment.

In D79305#2017632 <https://reviews.llvm.org/D79305#2017632>, @ldionne wrote:

> LGTM generally speaking, but is this triggered by a specific failure you ran into? If so, on what configuration? We should have a way to test this change.


built libc++ for my hobby OS but this looked general enough to include upstream. The 
`__APPLE__` check is probably not required with the new one in place.

> Also, next time, please include context in your Phabricator diff.

OK, will do. Phabricator was a bit confusing, first time usage ^^'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79305/new/

https://reviews.llvm.org/D79305





More information about the llvm-commits mailing list