[PATCH] D79328: lld: Let find_package(LLD) work

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 07:59:45 PDT 2020


arsenm created this revision.
arsenm added reviewers: beanz, davezarzycki, smeenai, labath, tstellar, Bigcheese, chandlerc.
Herald added subscribers: dexonsmith, mgorny, wdng.

Install a cmake config file. Copied exactly from how clang exports.

      

I'm slightly confused since it looks like the build is manually
generating a very similar *Targets.cmake to what gets auto-generated
by export(). After generating the build, I see:

  
  build/tools/lld/cmake/modules/CMakeFiles/Export/lib/cmake/lld/LLDTargets.cmake
  build/lib/cmake/lld/LLDTargets.cmake
  build/tools/clang/cmake/modules/CMakeFiles/Export/lib/cmake/clang/ClangTargets.cmake
  build/lib/cmake/clang/ClangTargets.cmake


The cmake generated one "wins" and is what I see in the installed
tree. I'm guessing this is somehow for the benefit of old versions
of cmake?

      

I also wasn't sure whether the canonical capitalization is "lld" or
"LLD". The project() is still calling this lld, but most places seemed
to capitalize it.


https://reviews.llvm.org/D79328

Files:
  lld/CMakeLists.txt
  lld/cmake/modules/AddLLD.cmake
  lld/cmake/modules/CMakeLists.txt
  lld/cmake/modules/LLDConfig.cmake.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79328.261813.patch
Type: text/x-patch
Size: 5174 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200504/2a438e52/attachment.bin>


More information about the llvm-commits mailing list