[PATCH] D78615: [ValueTracking] Let propagatesPoison support binops/unaryops/cast/etc.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM - see inline for some grammar nits.



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:565
 
-  /// Return true if this function can prove that I is guaranteed to yield
-  /// poison if at least one of its operands is poison.
+  /// Return true if I yields poison or raise UB if any of its operands is
+  /// poison.
----------------
raise -> raises


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:569
+  /// if, for all i, r is evaluated to poison or op raises UB if vi = poison.
+  /// To filter out the operand that raise UB on poison, you can use
+  /// getGuaranteedNonPoisonOp.
----------------
the operand -> operands


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4864
+
+    // Be conservative and return false
     return false;
----------------
Add period to end of sentence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78615/new/

https://reviews.llvm.org/D78615