[PATCH] D78342: [lld] Add archive file support to Mach-O backend

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/MachO/Arch/X86_64.cpp:34-37
+  case X86_64_RELOC_BRANCH:
   case X86_64_RELOC_SIGNED:
   case X86_64_RELOC_GOT_LOAD:
+  case X86_64_RELOC_SIGNED_1:
----------------
Ktwu wrote:
> int3 wrote:
> > are these two relocations used in this diff's tests?
> Yup.
Don't change X86_64_RELOC_SIGNED_1 which is unrelated to the main purpose of the patch.

Use other existing relocation types.


================
Comment at: lld/MachO/SymbolTable.cpp:77
+  std::tie(s, wasInserted) = insert(name);
+
+  if (wasInserted)
----------------
How does an archive symbol interact with a DylibSymbol?


================
Comment at: lld/test/MachO/bad-archive.s:1
+# REQUIRES: x86
+# RUN: echo "!<arch>" > %t.a
----------------
You could also create `invalid/` and place such tests there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78342/new/

https://reviews.llvm.org/D78342