[PATCH] D77689: Codegen for call setup
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 3 09:33:28 PDT 2020
jdoerfert added a comment.
Nit: The commit name is still call setup.
Did the lang ref patch land already? We should link it in the commit message.
The `llvm/lib/Transforms/IPO` look straight forward except the one in `llvm/lib/Transforms/IPO/GlobalOpt.cpp`. I would suggest to split that one off and add a comment to the new code explaining what is happening and why. It also seems that not all IPO passes have tests with the new attribute. Don't wait for me to review the rest or to accept this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77689/new/
https://reviews.llvm.org/D77689
More information about the llvm-commits
mailing list