[PATCH] D79258: [AutoFDO] Handling must tail calls in indirect call promotion

Sun May 3 08:29:42 PDT 2020

wenlei accepted this revision.
wenlei added a comment.

In D79258#2016607 <https://reviews.llvm.org/D79258#2016607>, @hoyFB wrote:

> In D79258#2016601 <https://reviews.llvm.org/D79258#2016601>, @wenlei wrote:
>
> > Forgot to mention earlier - this is not unique to AutoFDO, so you may want to change the title.
>
>
> Good point. I was thinking `[Codegen] ... ` as the title. Maybe `[ICP] ...`?  Not sure about the convention. @davidxl What do you think? Thanks.

Grepping the history, I found a few titled with `[ICP]..`, so yeah, that's used. `[TailCallElim]` is also used, though I don't have preference between the two. Looks good otherwise - thanks for the fix!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79258/new/

https://reviews.llvm.org/D79258