[PATCH] D79215: [llvm][NFC] Inliner: simplify inlining decision logic
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 2 19:36:51 PDT 2020
davidxl added a comment.
I believe there are other paths in the code that computes to None thus the use of Optional<..>. What I meant is the new dropping to None in the original version of the patch. Never is used for noinline attribute so we don't want to convert other do not inline into it.
Having a new wrapper class for 2 uses do look like a borderline overkill -- so revert to the original version is fine to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79215/new/
https://reviews.llvm.org/D79215
More information about the llvm-commits
mailing list