[llvm] 7867f4c - [PDB] Remove a couple asserts that are no longer valid now that C13Builders does not use unique_ptr.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sat May 2 17:31:32 PDT 2020


Author: Craig Topper
Date: 2020-05-02T17:31:10-07:00
New Revision: 7867f4c15f7763fd8d39cc2ffdcc19c22f49550d

URL: https://github.com/llvm/llvm-project/commit/7867f4c15f7763fd8d39cc2ffdcc19c22f49550d
DIFF: https://github.com/llvm/llvm-project/commit/7867f4c15f7763fd8d39cc2ffdcc19c22f49550d.diff

LOG: [PDB] Remove a couple asserts that are no longer valid now that C13Builders does not use unique_ptr.

These asserts used to check that unique_ptr was not null.

This fixes failures from 7af4bb16417deeb1d01e7dbbbb2272f1f46753c6

Added: 
    

Modified: 
    llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp b/llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
index 9b243006c5f8..73801ea1dd1b 100644
--- a/llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
@@ -89,7 +89,6 @@ void DbiModuleDescriptorBuilder::addSourceFile(StringRef Path) {
 uint32_t DbiModuleDescriptorBuilder::calculateC13DebugInfoSize() const {
   uint32_t Result = 0;
   for (const auto &Builder : C13Builders) {
-    assert(Builder && "Empty C13 Fragment Builder!");
     Result += Builder.calculateSerializedLength();
   }
   return Result;
@@ -163,7 +162,6 @@ Error DbiModuleDescriptorBuilder::commit(BinaryStreamWriter &ModiWriter,
            "Invalid debug section alignment!");
     // TODO: Write C11 Line data
     for (const auto &Builder : C13Builders) {
-      assert(Builder && "Empty C13 Fragment Builder!");
       if (auto EC = Builder.commit(SymbolWriter, CodeViewContainer::Pdb))
         return EC;
     }


        


More information about the llvm-commits mailing list