[PATCH] D79286: [ELF] Move SHF_LINK_ORDER till OutputSection addresses are known

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2131
   finalizeAddressDependentContent();
+  if (errorCount())
+    return;
----------------
Confirmed that `gc-sections-linkorder-err.s` (initially added in D67761) needs early-return here.


================
Comment at: lld/test/ELF/linkorder-script.s:23
+_start:
+.quad 0
+
----------------
grimar wrote:
> nit: I'd probably just use `nop` for `text*`
You can use `nop` for .text* and `.byte` for .linkorder*

Everything being one-byte makes it easier to recognize the section order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79286/new/

https://reviews.llvm.org/D79286