[PATCH] D79037: [StructurizeCFG] Fix region nodes ordering

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

It seems the new commit is an incremental update on the previous commit. Can you please submit a single squashed commit, so that the change can be compared against the original state of the trunk?

Also, the following tests were created specifically to demonstrate the wrong ordering:

- test/Transforms/StructurizeCFG/workarounds/needs-unified-loop-exits.ll
- test/Transforms/StructurizeCFG/workarounds/needs-fr-ule.ll

If the proposed change is correct, then the example in these tests will be structurized correctly even after removing the "-unify-loop-exits" argument. These tests should also be checked and then updated accordingly.

In fact, it would be nice to update the following tests. But they have a very confusing history and they are specific to AMDGPU. I can volunteer to do this later as a follow up.

- test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug.ll
- test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug-xfail.ll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79037/new/

https://reviews.llvm.org/D79037