[PATCH] D79002: [NFC][CostModel] Add TargetCostKind to relevant APIs

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D79002#2014512 <https://reviews.llvm.org/D79002#2014512>, @samparker wrote:

> Mail thread: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141263.html


Thanks - I meant in the commit message, so folks can readily reference it when they git log, for instance. Anyway, just a nit.



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:926
                       unsigned AddressSpace,
+                      TTI::TargetCostKind CostKind,
                       const Instruction *I = nullptr) const;
----------------
samparker wrote:
> mtrofin wrote:
> > Why not also default value CostKind here, too?
> Just because I really wasn't sure what it should be.
Looking at the uses of the API, it seems users pass TCK_RecipThroughput, which I think is the default for the other APIs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79002/new/

https://reviews.llvm.org/D79002