[PATCH] D79271: [mlir][Linalg] Mostly NFC - Refactor Linalg patterns and transformations.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

I'm happy to see this revision. I had exactly the same impression on DRR when it was being proposed for scheduling purposes - it's really not a fit, and in many ways goes backward from scheduling constructs written in C++ or other approaches. On a note related to this revision, the affine dialect has a number of standalone utilities to perform composable transformations - these can't be used from inside a pattern rewriter because some of them erase and insert ops and these are disallowed in/break the pattern rewriting framework. How do you propose to deal with that issue in the linalg world? It's common to any approach that's making "more than local" transformations and "local" SSA transformations which is what rewrite rules are designed for and excel in the LLVM world.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79271/new/

https://reviews.llvm.org/D79271