[PATCH] D79271: [mlir][Linalg] Mostly NFC - Refactor Linalg patterns and transformations.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 8 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h:140
+
+//----------------------------------------------------------------------------//
+// Transformations exposed as rewrite patterns.
----------------
rriddle wrote:
> ```
> //===---...---===//
> ```
ugh sorry .. thanks!


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp:118
+  auto tileRes =
+      (true) ? tileLinalgOp(rewriter, linalgOp, tileSizes, interchangeVector)
+             : tileLinalgOpToParallelLoops(rewriter, linalgOp, tileSizes,
----------------
rriddle wrote:
> This looks weird. This always resolves to tileLinalgOp.
Thanks for spotting, fixed and added a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79271/new/

https://reviews.llvm.org/D79271